feat!: define wrappers around package that point to internals #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1561 So far just top level things, can add inner ones (cfg, blocks, etc.) later. BREAKING CHANGE: `Package` moved to new `hugr.package` module
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
==========================================
+ Coverage 85.68% 85.69% +0.01%
==========================================
Files 134 135 +1
Lines 24512 24563 +51
Branches 21512 21512
==========================================
+ Hits 21003 21050 +47
- Misses 2411 2415 +4
Partials 1098 1098
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mark-koch
reviewed
Oct 11, 2024
hugr-py/src/hugr/package.py
Outdated
Comment on lines
52
to
54
| def get_package(self) -> Package: | ||
| """Get the package pointed to.""" | ||
| return self.package |
There was a problem hiding this comment.
What is the purpose of this method?
There was a problem hiding this comment.
(vestigial from original issue which proposed protocols)
mark-koch
reviewed
Oct 11, 2024
Comment on lines
+63
to
+65
| def module(self) -> Hugr: | ||
| """Hugr definition of the module.""" | ||
| return self.package.modules[self.module_index] |
There was a problem hiding this comment.
This could be a property (same for all other methods in this PR)
aborgna-q
approved these changes
Oct 11, 2024
hugr-py/src/hugr/package.py
Outdated
| """Create an executable package from a module containing a main function. | ||
|
|
||
| Raises: | ||
| StopIteration: If the module does not contain a main function. |
There was a problem hiding this comment.
Rethrow a more appropriate exception, with a custom message.
Either a custom one, or ValueError
hugr-py/src/hugr/package.py
Outdated
| """Hugr definition of the module.""" | ||
| return self.package.modules[self.module_index] | ||
|
|
||
| def to_executable_package(self) -> "ExecutablePackage": |
There was a problem hiding this comment.
from __future__ import annotationsand remove the quotes
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
🤖 I have created a release *beep* *boop* --- ## [0.9.0](hugr-py-v0.8.1...hugr-py-v0.9.0) (2024-10-14) ### ⚠ BREAKING CHANGES * `Package` moved to new `hugr.package` module * The `length` op in the std `collections` extensions now also returns the list. ### Features * `instantiate` method for `OpDef` ([#1576](#1576)) ([36548ab](36548ab)), closes [#1512](#1512) * define wrappers around package that point to internals ([#1573](#1573)) ([f74dbf3](f74dbf3)) * to/from json for extension/package ([#1575](#1575)) ([f8bf61a](f8bf61a)), closes [#1523](#1523) ### Bug Fixes * Make list length op give back the list ([#1547](#1547)) ([cf31698](cf31698)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1561
So far just top level things, can add inner ones (cfg, blocks, etc.) later.
BREAKING CHANGE:
Packagemoved to newhugr.packagemodule